Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve] [bk] Update the document of diskUsageWarnThreshold #21142

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[improve] [bk] Update the document of diskUsageWarnThreshold #21142

merged 1 commit into from
Sep 14, 2023

Conversation

hangc0276
Copy link
Contributor

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

In conf/bookkeeper.conf, the document and default values of diskUsageWarnThreshold and diskUsageLwmThreshold are not synced with the code.

Modifications

Update the document and default value of diskUsageWarnThreshold and diskUsageLwmThreshold

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@hangc0276 hangc0276 self-assigned this Sep 7, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 7, 2023
@hangc0276 hangc0276 added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-not-needed Your PR changes do not impact docs labels Sep 7, 2023
@hangc0276 hangc0276 added this to the 3.2.0 milestone Sep 7, 2023
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Sep 7, 2023
@hangc0276 hangc0276 added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test labels Sep 7, 2023
@github-actions github-actions bot removed the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 7, 2023
@hangc0276 hangc0276 changed the title [doc] [bookie] Update the document of diskUsageWarnThreshold [improve] [bookie] Update the document of diskUsageWarnThreshold Sep 7, 2023
@Technoboy- Technoboy- changed the title [improve] [bookie] Update the document of diskUsageWarnThreshold [improve] [bk] Update the document of diskUsageWarnThreshold Sep 8, 2023
@Technoboy- Technoboy- closed this Sep 13, 2023
@Technoboy- Technoboy- reopened this Sep 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #21142 (1270d28) into master (88231f7) will decrease coverage by 1.10%.
Report is 16 commits behind head on master.
The diff coverage is 74.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21142      +/-   ##
============================================
- Coverage     73.21%   72.11%   -1.10%     
+ Complexity    32452    32449       -3     
============================================
  Files          1887     1887              
  Lines        140004   144536    +4532     
  Branches      15423    16667    +1244     
============================================
+ Hits         102502   104238    +1736     
- Misses        29410    31958    +2548     
- Partials       8092     8340     +248
Flag Coverage Δ
inttests 24.01% <40.74%> (-0.18%) ⬇️
systests 25.07% <33.33%> (+0.08%) ⬆️
unittests 72.49% <70.96%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...java/org/apache/pulsar/broker/rest/TopicsBase.java 58.31% <50.00%> (ø)
...sar/broker/service/persistent/PersistentTopic.java 79.92% <50.00%> (-0.62%) ⬇️
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java 69.69% <80.00%> (-9.61%) ⬇️
.../bookkeeper/mledger/impl/NonDurableCursorImpl.java 85.41% <100.00%> (+1.32%) ⬆️

... and 77 files with indirect coverage changes

@Technoboy- Technoboy- merged commit 39f2d1d into apache:master Sep 14, 2023
99 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@zymap zymap Awaiting requested review from zymap

Assignees

@hangc0276 hangc0276

Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hangc0276 @codecov-commenter @Technoboy- @poorbarcode @mattisonchao